Prompt for Google account selection every time on log in. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find @mrabbitt, but it doesn't really prompt for sign-in it just prompts for account selection. I am not challenged for my password. |
@thomhickey This change is not intended to address your "issue" that it doesn't ask for a password. I don't think it's clear that this should be a requirement of Compass. I think we should wait for clarification or firm requirements from our PM and/or SFUSD. Thanks. |
|
Right on, just wanted to be clear because your PR title says prompt for google sign-in. |
mrabbitt
changed the title
|
PR title updated to clarify scope. |
mrabbitt
force-pushed
the
force-google-relogin
branch
from
f46f7e7
to
7585f72
Compare
|
Taking out of draft to consider it as a fix for #441 |
mrabbitt
force-pushed
the
force-google-relogin
branch
from
7585f72
to
1fd186a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I think this change is probably a good idea, but would like to hear what others think, so I've left it as a draft PR for now.)
Currently, when you logout of Compass, and then sign in again with the "Sign in with Google" buton on the Sign In page, the Students page is loaded immediately without prompting for confirmation or selection of which Google account to use.
I figured out how to force the Google NextAuth provider to prompt for Google account selection and confirmation every time the "Sign in with Google" button is clicked. Note that if a user never logs out of Compass or clears their auth cookies, they will still stay signed in.
For what it's worth, I checked the behavior of the Logout link in Figma using Google SSO, and it also prompts for account selection and confirmation when logging back in afterward.
Before this change:
Screen.Recording.2024-08-30.at.3.46.23.PM.mov
After this change:
Screen.Recording.2024-08-30.at.3.45.29.PM.mov